Skip to content

Commit 62012e2

Browse files
ci: run windows inprocess .NET SDK tests on net8.0 only
The net472 target adds no in-process transport coverage; restrict the windows inprocess leg to net8.0 (net472 stays covered by the windows default leg). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 2e4e2da commit 62012e2

1 file changed

Lines changed: 12 additions & 1 deletion

File tree

.github/workflows/dotnet-sdk-tests.yml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,4 +88,15 @@ jobs:
8888
- name: Run .NET SDK tests
8989
env:
9090
COPILOT_HMAC_KEY: ${{ secrets.COPILOT_DEVELOPER_CLI_INTEGRATION_HMAC_KEY }}
91-
run: dotnet test --no-build -v n
91+
run: |
92+
# In-process (FFI) hosting is only exercised on .NET (Core). The .NET
93+
# Framework (net472) target does not add coverage for the in-process
94+
# transport, so on Windows restrict the inprocess leg to net8.0. net472
95+
# is still covered by the windows default-transport leg.
96+
# TODO: Re-enable net472 for inprocess after fixing in-process sqlite
97+
# file locking on shutdown on Windows.
98+
framework_arg=""
99+
if [ "${{ runner.os }}" = "Windows" ] && [ "${{ matrix.transport }}" = "inprocess" ]; then
100+
framework_arg="--framework net8.0"
101+
fi
102+
dotnet test --no-build -v n $framework_arg

0 commit comments

Comments
 (0)