1140 followup review fixes 2#1268
Open
l2ysho wants to merge 12 commits into
Open
Conversation
…nsts Derive JobStatus and JobType from @apify/consts and use them across agent-output.ts and useAbortJobOnSignal instead of stringly-typed parameters, updating all call sites to ACTOR_JOB_TYPES. Resolves #1168 (comment)
Covers waitForTerminalStatus polling/timeout/not-found behavior and the isTerminalStatus/exitCodeForJobStatus/exitCodeForWaitResult tables. Resolves #1168 (comment)
fetchRunLogTail keeps its succeeded-run guard and 10-line tail but delegates the fetch/split/slice to the shared fetchLogTail, which now also trims trailing whitespace. Resolves #1168 (comment)
Add consoleActorUrl and consoleKeyValueStoreUrl, use the builders in start/call/run-result/runs info/builds info instead of inlined URLs, and standardize build URLs on the /builds/ path format. Resolves #1168 (comment)
Add a generic overload mapping kind to Build/ActorRun so callers no longer cast the returned job. Resolves #1168 (comment) Resolves #1168 (comment) Resolves #1168 (comment)
l2ysho
added
t-builders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup fixes from #1168
closes #1135