decouple NamingStrategy from C2J Shape via ShapeContext#7133
Open
Fred1155 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
NamingStrategytakessoftware.amazon.awssdk.codegen.model.service.Shape(a C2J type) in seven of its methods. The strategy only reads five predicates from that parameter (isUnion,isException,isOrContainsEnum,isList,isMap). Coupling the interface to a specific model type would force any non-C2J caller to fabricate aShapejust to satisfy the signature.Modifications
ShapeContextinterface exposing the five predicates the strategy actually reads.NamingStrategymethods now takeShapeContextin place ofShape.DefaultNamingStrategyupdated to read predicates viaShapeContext; algorithm unchanged.AddShapes(the only caller) wraps itsShapeviaShapeContext.ofC2j(shape, allShapes)at the call site.NamingStrategyis codegen-internal, not@SdkPublicApi, andcodegen/is excluded from japicmp — no public API impact.Testing
ShapeContextTestverifiesofC2jwires each predicate to the correct backing accessor and thatisOrContainsEnumrecurses throughallShapesfor list/map members.DefaultNamingStrategyTestcases updated to the new signature; behavior assertions unchanged.mvn clean install -pl :codegenpasses.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License