ggml-cpu: gelu optimizqation using simd#3939
Open
ameya-ms wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation:
Copies the same implementation as ggml_vec_silu_f32. Adding for AVX2, AVX512, NEON, and SVE. SSE2 uses the f16 table look-up.
Rewrote GELU function to only use exp instead of tanh.
Testing:
Edge cases vs scalar reference (0, ±inf, nan, saturated tails, tiny values,
and the scalar tail loop) pass on AVX-512, AVX2 and SSE2 builds.
Compiled and run on x86 AVX-512 / AVX2 / SSE4.2 builds. NEON/SVE compile-only
(not run — no ARM hardware).
SSE2 uses old version (everything else uses new version):
Numbers below are strictly comparing old/new version.
Notice
-inf->-nan(ind)