Track compiled lock files for the new test workflows#44551
Conversation
|
Hey The PR is currently
Once the lock files are committed and the If you'd like a hand finishing up, you can assign this prompt to your coding agent:
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot move test workflows to pkg/cli/workflows |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Addressed in fa10c99. The four test workflows now live under |
There was a problem hiding this comment.
Pull request overview
This PR introduces several new “test-*” workflow markdown sources under pkg/cli/workflows/ (plus a shared OTLP import), updates the AddResolvedWorkflows unit test to operate inside a temporary git repo, and adjusts the agent-factory status docs table by removing entries for some test workflows.
Changes:
- Added four new test workflow markdown fixtures (
test-workflow,test-dispatcher,test-project-url-default,test-create-pr-error-handling) plus a sharedshared/otlp.mdimport underpkg/cli/workflows/. - Updated
TestAddResolvedWorkflowsto run in a temp directory withgit initand to assert the workflow file is written. - Updated
agent-factory-status.mdxby removing rows for the test workflows.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/workflows/test-workflow.md | Adds a dispatcher target workflow fixture with workflow_dispatch inputs. |
| pkg/cli/workflows/test-project-url-default.md | Adds a fixture to validate explicit project requirements in safe outputs. |
| pkg/cli/workflows/test-dispatcher.md | Adds a fixture demonstrating dispatch-workflow safe outputs and generated MCP tooling. |
| pkg/cli/workflows/test-create-pr-error-handling.md | Adds a fixture intended to exercise create_pull_request error handling. |
| pkg/cli/workflows/shared/otlp.md | Adds a shared OTLP observability import used by the new fixtures. |
| pkg/cli/add_command_test.go | Makes TestAddResolvedWorkflows run in a temp git repo and asserts output is written. |
| docs/src/content/docs/agent-factory-status.mdx | Removes agent-factory status table entries for the test workflows. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/7 changed files
- Comments generated: 2
- Review effort level: Low
| | [Super Linter Report](https://github.com/github/gh-aw/blob/main/.github/workflows/super-linter.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/super-linter.lock.yml) | `daily around 14:00 on weekdays` | - | | ||
| | [Team Status](https://github.com/github/gh-aw/blob/main/.github/workflows/daily-team-status.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/daily-team-status.lock.yml) | - | - | | ||
| | [Terminal Stylist](https://github.com/github/gh-aw/blob/main/.github/workflows/terminal-stylist.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/terminal-stylist.lock.yml) | - | - | | ||
| | [Test Create PR Error Handling](https://github.com/github/gh-aw/blob/main/.github/workflows/test-create-pr-error-handling.md) | claude | [](https://github.com/github/gh-aw/actions/workflows/test-create-pr-error-handling.lock.yml) | - | - | | ||
| | [Test Dispatcher Workflow](https://github.com/github/gh-aw/blob/main/.github/workflows/test-dispatcher.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/test-dispatcher.lock.yml) | - | - | | ||
| | [Test Project URL Explicit Requirement](https://github.com/github/gh-aw/blob/main/.github/workflows/test-project-url-default.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/test-project-url-default.lock.yml) | - | - | | ||
| | [Test Quality Sentinel](https://github.com/github/gh-aw/blob/main/.github/workflows/test-quality-sentinel.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/test-quality-sentinel.lock.yml) | - | - | | ||
| | [Test Workflow](https://github.com/github/gh-aw/blob/main/.github/workflows/test-workflow.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/test-workflow.lock.yml) | - | - | | ||
| | [The Daily Repository Chronicle](https://github.com/github/gh-aw/blob/main/.github/workflows/daily-repo-chronicle.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/daily-repo-chronicle.lock.yml) | `daily around 16:00 on weekdays` | - | |
| oldWd, err := os.Getwd() | ||
| require.NoError(t, err) | ||
| require.NoError(t, os.Chdir(tmpDir)) | ||
| defer func() { | ||
| require.NoError(t, os.Chdir(oldWd)) | ||
| }() |
The firewall bump added four test workflow markdown sources, but their compiled
.lock.ymlartifacts were not trackable in Git because the repository ignoredtest-*.lock.ymlunder.github/workflows. This change makes those specific workflow artifacts part of the repo so the workflows can be executed by GitHub Actions.Root cause
.github/workflows/test-*.lock.ymlwas ignored globally for test workflows.What changed
.gitignoreexceptions for:test-create-pr-error-handling.lock.ymltest-dispatcher.lock.ymltest-project-url-default.lock.ymltest-workflow.lock.ymlResult