Skip to content

Track compiled lock files for the new test workflows#44551

Merged
pelikhan merged 3 commits into
mainfrom
copilot/aw-44467-add-lock-yml-files
Jul 9, 2026
Merged

Track compiled lock files for the new test workflows#44551
pelikhan merged 3 commits into
mainfrom
copilot/aw-44467-add-lock-yml-files

Conversation

Copilot AI commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

The firewall bump added four test workflow markdown sources, but their compiled .lock.yml artifacts were not trackable in Git because the repository ignored test-*.lock.yml under .github/workflows. This change makes those specific workflow artifacts part of the repo so the workflows can be executed by GitHub Actions.

  • Root cause

    • .github/workflows/test-*.lock.yml was ignored globally for test workflows.
    • The four new compiled artifacts existed as valid generated outputs but could not be committed.
  • What changed

    • Added narrow .gitignore exceptions for:
      • test-create-pr-error-handling.lock.yml
      • test-dispatcher.lock.yml
      • test-project-url-default.lock.yml
      • test-workflow.lock.yml
    • Added the generated lock files for those workflows.
  • Result

    • These four test workflows now follow the same compile-and-commit model as other tracked workflow fixtures.
    • GitHub Actions can resolve and run the compiled workflows from the repository.
.github/workflows/test-*.lock.yml
!.github/workflows/test-create-pr-error-handling.lock.yml
!.github/workflows/test-dispatcher.lock.yml
!.github/workflows/test-project-url-default.lock.yml
!.github/workflows/test-workflow.lock.yml

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Hey @Copilot 👋 — thanks for picking up this P2 maintenance task! Generating the missing .lock.yml files for the four test workflows is exactly the right fix.

The PR is currently [WIP] with no files committed yet. Here's what's needed to complete it:

  • Compile and commit the 4 lock files — run gh aw compile on each of the four .md files listed in the issue and commit the generated .lock.yml outputs. That's the sole remaining step.
  • Tests — no test changes are expected for compiled artifact generation, so this isn't a blocker, but make sure the compiled output is valid (i.e., gh aw compile exits cleanly for all four workflows).

Once the lock files are committed and the [WIP] prefix is dropped from the title, this should be ready for review.

If you'd like a hand finishing up, you can assign this prompt to your coding agent:

Complete PR #44551 in github/gh-aw by generating and committing the 4 missing .lock.yml files.

Run the following commands from the repo root:

  gh aw compile .github/workflows/test-create-pr-error-handling.md
  gh aw compile .github/workflows/test-dispatcher.md
  gh aw compile .github/workflows/test-project-url-default.md
  gh aw compile .github/workflows/test-workflow.md

Verify each command exits cleanly (no compilation errors). Then stage and commit the 4 generated .lock.yml files with commit message:

  chore: generate missing .lock.yml files for test workflows (#44511)

Finally, remove the [WIP] prefix from the PR title.

Generated by ✅ Contribution Check · 138 AIC · ⌖ 20.1 AIC · ⊞ 6.2K ·

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add missing .lock.yml files for test workflows Track compiled lock files for the new test workflows Jul 9, 2026
Copilot AI requested a review from pelikhan July 9, 2026 14:02
@pelikhan

pelikhan commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

@copilot move test workflows to pkg/cli/workflows

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@copilot move test workflows to pkg/cli/workflows

Addressed in fa10c99. The four test workflows now live under pkg/cli/workflows, the .github/workflows lock files were removed, the original .gitignore behavior was restored, and the affected CLI test was updated to avoid depending on the old fixture location.

@pelikhan pelikhan marked this pull request as ready for review July 9, 2026 18:07
Copilot AI review requested due to automatic review settings July 9, 2026 18:07
@pelikhan pelikhan merged commit f2bff5d into main Jul 9, 2026
@pelikhan pelikhan deleted the copilot/aw-44467-add-lock-yml-files branch July 9, 2026 18:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces several new “test-*” workflow markdown sources under pkg/cli/workflows/ (plus a shared OTLP import), updates the AddResolvedWorkflows unit test to operate inside a temporary git repo, and adjusts the agent-factory status docs table by removing entries for some test workflows.

Changes:

  • Added four new test workflow markdown fixtures (test-workflow, test-dispatcher, test-project-url-default, test-create-pr-error-handling) plus a shared shared/otlp.md import under pkg/cli/workflows/.
  • Updated TestAddResolvedWorkflows to run in a temp directory with git init and to assert the workflow file is written.
  • Updated agent-factory-status.mdx by removing rows for the test workflows.
Show a summary per file
File Description
pkg/cli/workflows/test-workflow.md Adds a dispatcher target workflow fixture with workflow_dispatch inputs.
pkg/cli/workflows/test-project-url-default.md Adds a fixture to validate explicit project requirements in safe outputs.
pkg/cli/workflows/test-dispatcher.md Adds a fixture demonstrating dispatch-workflow safe outputs and generated MCP tooling.
pkg/cli/workflows/test-create-pr-error-handling.md Adds a fixture intended to exercise create_pull_request error handling.
pkg/cli/workflows/shared/otlp.md Adds a shared OTLP observability import used by the new fixtures.
pkg/cli/add_command_test.go Makes TestAddResolvedWorkflows run in a temp git repo and asserts output is written.
docs/src/content/docs/agent-factory-status.mdx Removes agent-factory status table entries for the test workflows.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/7 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment on lines 238 to 242
| [Super Linter Report](https://github.com/github/gh-aw/blob/main/.github/workflows/super-linter.md) | copilot | [![Super Linter Report](https://github.com/github/gh-aw/actions/workflows/super-linter.lock.yml/badge.svg)](https://github.com/github/gh-aw/actions/workflows/super-linter.lock.yml) | `daily around 14:00 on weekdays` | - |
| [Team Status](https://github.com/github/gh-aw/blob/main/.github/workflows/daily-team-status.md) | copilot | [![Team Status](https://github.com/github/gh-aw/actions/workflows/daily-team-status.lock.yml/badge.svg)](https://github.com/github/gh-aw/actions/workflows/daily-team-status.lock.yml) | - | - |
| [Terminal Stylist](https://github.com/github/gh-aw/blob/main/.github/workflows/terminal-stylist.md) | copilot | [![Terminal Stylist](https://github.com/github/gh-aw/actions/workflows/terminal-stylist.lock.yml/badge.svg)](https://github.com/github/gh-aw/actions/workflows/terminal-stylist.lock.yml) | - | - |
| [Test Create PR Error Handling](https://github.com/github/gh-aw/blob/main/.github/workflows/test-create-pr-error-handling.md) | claude | [![Test Create PR Error Handling](https://github.com/github/gh-aw/actions/workflows/test-create-pr-error-handling.lock.yml/badge.svg)](https://github.com/github/gh-aw/actions/workflows/test-create-pr-error-handling.lock.yml) | - | - |
| [Test Dispatcher Workflow](https://github.com/github/gh-aw/blob/main/.github/workflows/test-dispatcher.md) | copilot | [![Test Dispatcher Workflow](https://github.com/github/gh-aw/actions/workflows/test-dispatcher.lock.yml/badge.svg)](https://github.com/github/gh-aw/actions/workflows/test-dispatcher.lock.yml) | - | - |
| [Test Project URL Explicit Requirement](https://github.com/github/gh-aw/blob/main/.github/workflows/test-project-url-default.md) | copilot | [![Test Project URL Explicit Requirement](https://github.com/github/gh-aw/actions/workflows/test-project-url-default.lock.yml/badge.svg)](https://github.com/github/gh-aw/actions/workflows/test-project-url-default.lock.yml) | - | - |
| [Test Quality Sentinel](https://github.com/github/gh-aw/blob/main/.github/workflows/test-quality-sentinel.md) | copilot | [![Test Quality Sentinel](https://github.com/github/gh-aw/actions/workflows/test-quality-sentinel.lock.yml/badge.svg)](https://github.com/github/gh-aw/actions/workflows/test-quality-sentinel.lock.yml) | - | - |
| [Test Workflow](https://github.com/github/gh-aw/blob/main/.github/workflows/test-workflow.md) | copilot | [![Test Workflow](https://github.com/github/gh-aw/actions/workflows/test-workflow.lock.yml/badge.svg)](https://github.com/github/gh-aw/actions/workflows/test-workflow.lock.yml) | - | - |
| [The Daily Repository Chronicle](https://github.com/github/gh-aw/blob/main/.github/workflows/daily-repo-chronicle.md) | copilot | [![The Daily Repository Chronicle](https://github.com/github/gh-aw/actions/workflows/daily-repo-chronicle.lock.yml/badge.svg)](https://github.com/github/gh-aw/actions/workflows/daily-repo-chronicle.lock.yml) | `daily around 16:00 on weekdays` | - |
Comment on lines +155 to +160
oldWd, err := os.Getwd()
require.NoError(t, err)
require.NoError(t, os.Chdir(tmpDir))
defer func() {
require.NoError(t, os.Chdir(oldWd))
}()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] 4 test workflows missing .lock.yml files after firewall bump #44467

3 participants