fix(templates): correct phase numbering in plan.md#3416
Open
marcelsafin wants to merge 1 commit into
Open
Conversation
The plan command's outline listed two bullets labeled Phase 1 and the completion report said the command ends after "Phase 2 planning", but the Phases section only defines Phase 0 and Phase 1. Phase 2 (tasks.md) belongs to the tasks command, as plan-template.md states. The duplicated "Phase 1: Update agent context" bullet is a leftover from before the agent-context extension: core no longer ships an agent script, and the update runs via the extension's after_plan hook. Fixes github#1036 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes contradictory phase numbering and outdated instructions in the speckit.plan command template so the Outline/Completion Report align with the defined phases and current agent-context extension workflow.
Changes:
- Removes a stale duplicate “Phase 1” bullet about updating agent context via an agent script.
- Updates the Completion Report to state the command ends after “Phase 1 design” (consistent with the Phases section).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1036
Root cause
templates/commands/plan.mddrifted out of sync with its own Phases section:after_planhook (extensions/agent-context/extension.yml).speckit.tasks, exactly astemplates/plan-template.mdalready states ("NOT created by plan").Change
Two-line diff, no behavior change beyond removing contradictory instructions to the agent.
Testing
No tests pin this template's prose. Full suite untouched by the change.