Open
.NET: Enable Valkey NuGet package publishing#7059
Conversation
Copilot
AI
changed the title
[WIP] Update Valkey .NET package for publishing
Enable Valkey NuGet package publishing
Jul 10, 2026
Contributor
westey-m
approved these changes
Jul 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables Microsoft.Agents.AI.Valkey to be produced as a NuGet package in release builds by removing its explicit non-packable override and ensuring it is included in the release solution filter used by publish pipelines.
Changes:
- Removed the project-level
<IsPackable>false</IsPackable>override so Valkey inheritsIsPackable=truefromdotnet/nuget/nuget-package.props. - Added
Microsoft.Agents.AI.Valkeytodotnet/agent-framework-release.slnfso it participates in release packing/publishing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.Valkey/Microsoft.Agents.AI.Valkey.csproj | Removes the explicit pack-blocker so the project is eligible for NuGet packing via central props. |
| dotnet/agent-framework-release.slnf | Includes the Valkey project in the release solution filter used for publish flows. |
rogerbarreto
approved these changes
Jul 10, 2026
peibekwe
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Microsoft.Agents.AI.Valkeywas blocked from being published as a NuGet package due to an explicit<IsPackable>false</IsPackable>override. It also wasn't included in the release solution filter, so it was excluded from publish pipelines.Description & Review Guide
What are the major changes?
<IsPackable>false</IsPackable>(and its associated comment) fromMicrosoft.Agents.AI.Valkey.csproj, allowing it to inheritIsPackable=truefrom the centralnuget-package.props.Microsoft.Agents.AI.Valkeytoagent-framework-release.slnfin alphabetical order alongside the other publishable packages.What is the impact of these changes? The Valkey package will now be packed and published as a NuGet artifact in release builds.
What do you want reviewers to focus on? Confirm the
VersionSuffix=alphain the csproj is the intended pre-release label for the initial publish.Related Issue
Closes #7058
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.