Skip to content

.NET: Enable Valkey NuGet package publishing#7059

Open
westey-m with Copilot wants to merge 2 commits into
mainfrom
copilot/publish-valkey-nuget
Open

.NET: Enable Valkey NuGet package publishing#7059
westey-m with Copilot wants to merge 2 commits into
mainfrom
copilot/publish-valkey-nuget

Conversation

Copilot AI commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

Microsoft.Agents.AI.Valkey was blocked from being published as a NuGet package due to an explicit <IsPackable>false</IsPackable> override. It also wasn't included in the release solution filter, so it was excluded from publish pipelines.

Description & Review Guide

  • What are the major changes?

    • Removed <IsPackable>false</IsPackable> (and its associated comment) from Microsoft.Agents.AI.Valkey.csproj, allowing it to inherit IsPackable=true from the central nuget-package.props.
    • Added Microsoft.Agents.AI.Valkey to agent-framework-release.slnf in alphabetical order alongside the other publishable packages.
  • What is the impact of these changes? The Valkey package will now be packed and published as a NuGet artifact in release builds.

  • What do you want reviewers to focus on? Confirm the VersionSuffix=alpha in the csproj is the intended pre-release label for the initial publish.

Related Issue

Closes #7058

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.

Copilot AI requested review from Copilot and removed request for Copilot July 10, 2026 18:04
Copilot AI linked an issue Jul 10, 2026 that may be closed by this pull request
Copilot AI requested review from Copilot and removed request for Copilot July 10, 2026 18:06
Copilot AI changed the title [WIP] Update Valkey .NET package for publishing Enable Valkey NuGet package publishing Jul 10, 2026
Copilot AI requested a review from westey-m July 10, 2026 18:06
@westey-m westey-m marked this pull request as ready for review July 10, 2026 18:18
Copilot AI review requested due to automatic review settings July 10, 2026 18:18
@westey-m

Copy link
Copy Markdown
Contributor

CC @MatthiasHowellYopp

@giles17 giles17 added the .NET Usage: [Issues, PRs], Target: .Net label Jul 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables Microsoft.Agents.AI.Valkey to be produced as a NuGet package in release builds by removing its explicit non-packable override and ensuring it is included in the release solution filter used by publish pipelines.

Changes:

  • Removed the project-level <IsPackable>false</IsPackable> override so Valkey inherits IsPackable=true from dotnet/nuget/nuget-package.props.
  • Added Microsoft.Agents.AI.Valkey to dotnet/agent-framework-release.slnf so it participates in release packing/publishing.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
dotnet/src/Microsoft.Agents.AI.Valkey/Microsoft.Agents.AI.Valkey.csproj Removes the explicit pack-blocker so the project is eligible for NuGet packing via central props.
dotnet/agent-framework-release.slnf Includes the Valkey project in the release solution filter used for publish flows.

@github-actions github-actions Bot changed the title Enable Valkey NuGet package publishing .NET: Enable Valkey NuGet package publishing Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET: Publish Valkey nuget

6 participants