Check for expected content#325100
Open
chrmarti wants to merge 1 commit into
Open
Conversation
aeschli
approved these changes
Jul 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Copilot extension’s “collect diagnostics” networking probes to validate that each endpoint not only responds, but returns the expected kind of payload, improving the usefulness of diagnostics output when investigating connectivity/proxy issues.
Changes:
- Adds per-URL
expectedContentmarkers and checks fetched response bodies for those markers. - Enhances diagnostics output with a single-line “unexpected content” note (including truncation/formatting for readability).
- Introduces a helper to format unexpected response bodies for display.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/log/vscode-node/loggingActions.ts | Adds expected-content validation for diagnostic network probes and formats unexpected bodies for display. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
Comment on lines
+203
to
+212
| let contentNote = ''; | ||
| try { | ||
| const body = await response.text(); | ||
| if (!body.includes(expectedContent)) { | ||
| contentNote = ` - unexpected content: ${formatUnexpectedContent(body)} (expected: '${expectedContent}')`; | ||
| } | ||
| } catch (bodyErr) { | ||
| contentNote = ` - failed to read content: ${collectErrorMessages(bodyErr)}`; | ||
| } | ||
| await appendText(editor, `HTTP ${response.status} (${Date.now() - start} ms)${contentNote}\n`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.