You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On mobile, the Accessibility dropdown was being placed into an implicit grid row, which defaulted to auto height. This caused the dropdown to appear compressed compared to the Language dropdown and Search bar.
This change adds grid-auto-rows: var(--settings-container-height-touch) so implicit grid rows use the same height as the explicitly defined rows, keeping all controls consistently sized on mobile.
Hi @slash-init, thank you for this PR. I tested it locally, and here is what I found.
The height fix is correct and confirmed working. Adding grid-auto-rows: var(--settings-container-height-touch) ensures the Accessibility dropdown falls into an explicitly sized implicit grid row instead of defaulting to auto height. All three controls, Language, Accessibility, and Search, are now consistently sized on mobile.
Issue still remaining
The font size mismatch mentioned in issue #1480 is still not addressed. After inspecting:
Search bar font-size: 16px inherited from parent (no explicit font size set)
Language dropdown font-size: 0.75rem (12px) hardcoded
The dropdown text is hardcoded and set to 0.75rem (12px), which overrides inheritance and makes it smaller than the Search bar. The fix would be to either remove the hardcoded font-size: .75rem so the dropdowns inherit from the parent like Search does, or set it explicitly to match. @doradocodes, your thoughts on this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On mobile, the Accessibility dropdown was being placed into an implicit grid row, which defaulted to
autoheight. This caused the dropdown to appear compressed compared to the Language dropdown and Search bar.This change adds
grid-auto-rows: var(--settings-container-height-touch)so implicit grid rows use the same height as the explicitly defined rows, keeping all controls consistently sized on mobile.Before :

After:

Fixes #1480