fix(error-handling): prevent infinite recursion when errorHandler throws#13370
Open
ifer47 wants to merge 2 commits into
Open
fix(error-handling): prevent infinite recursion when errorHandler throws#13370ifer47 wants to merge 2 commits into
ifer47 wants to merge 2 commits into
Conversation
When a custom errorHandler throws an error, it triggers handleError again which calls the errorHandler again, causing infinite recursion and a "Maximum call stack size exceeded" error. Add an isHandlingError guard to prevent re-entering handleError while it's already processing an error. This ensures that errors thrown by the errorHandler itself are logged without causing recursive calls. Closes vuejs#13241 Co-Authored-By: zhipu/glm-5 <zai-org@claude-code-best.win>
Co-Authored-By: zhipu/glm-5 <zai-org@claude-code-best.win>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isHandlingErrorguard to prevent infinite recursion when the custom error handler itself throws an errorconfig.errorHandlerthrew, it would triggerhandleErroragain, which calls the error handler again, causing infinite recursion andMaximum call stack size exceededhandleErroris called while already handling an error, it returns early instead of re-entering the error handling flowProblem
When a custom
config.errorHandlerthrows an error, the following chain occurs:invokeWithErrorHandlingcatches the original errorhandleErrorhandleErrorcallsglobalHandleErrorglobalHandleErrorcallsconfig.errorHandlererrorHandlerthrows, it callslogErrorlogErroror any code path leads back toinvokeWithErrorHandling, the cycle repeatsRangeError: Maximum call stack size exceededChanges
isHandlingErrorflagtrueat the start ofhandleErrorpopTarget()if already handling an errorfalsein thefinallyblockCloses #13241
🤖 Generated with Claude Code Best